Merged
Conversation
The list of packages in the generated matrix can sometimes be empty, which is invalid and will result in the actual matrix of job runners failing to generate (because all values must be a non-empty array). This commit performs a final validation of job matrix, removing all default configs if the package list is empty, and removing the includes list if it is empty.
A mu_feature_ipmi and mu_feature_debugger do not support `stuart_setup` and thus would error because their config was set to `both`. This commit updates the config for these two repositories to only be `ci-setup`. Additionally, this commit removes mu_plus from being sync'd as it requires rust be configured. We do not plan on supporting this at this time.
Javagedes
force-pushed
the
personal/joeyvagedes/package-matrix-bugfix
branch
from
5333919 to
46744ba
Compare
apop5
approved these changes
Apr 3, 2026
makubacki
approved these changes
Apr 3, 2026
Member
makubacki
left a comment
makubacki
left a comment
There was a problem hiding this comment.
@Javagedes, can you please add a line to the top of clangpdb-ci.yml that says repos that build Rust are not supported? That would make it more obvious in case someone tries to sync it to mu_plus in the future.
I was going to depend on this workflow in my mu_plus workflow, but I'll update it.
This was referenced Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit pull-request does two things:
PackageMatrix.ymlto better support when there are no packages to test (See commit details).Files.ymlsync settings for a few repositories using the CLANGPDB CI (See commit details).Testing for (1):
Testing for (2):